Fixing microtasks and fleshing out raf #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakearchibald
force-pushed
the
patch-1
branch
from
30f073e to
a239c98
Compare
Author
|
I've split out the reindenting commit. The actual changes are at 9427d9b |
|
probably a tad easier to review without the whitespace changes: ?w=1 |
Author
|
TIL about ?w=1! However, I split out the commits, so you can also see 9427d9b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is bad since I changed the indenting so it'd syntax highlight as JS.
Summary:
executeMicrotasksto execute until the list is empty, including any additional items added.executeJSCallbackwhich should be called for all JS callbacks, including those from tasks, but there isn't really a way to express this.executeRequestAnimationFrameCallbacksto show that additional callbacks queued will happen in the next turn around the render loop.