feat: support for binary key values#374
Merged
akafredperry merged 2 commits intotrunkfrom Mar 23, 2026
Merged
Conversation
419bf1a to
6f2eb11
Compare
Contributor
|
LGTM but have you done cross-platform checks? (Java putter -> Dart getter, and vice versa) |
gkc
previously approved these changes
Mar 22, 2026
Collaborator
Author
good point, I will do this, thanks |
6f2eb11 to
ffb470e
Compare
gkc
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #369
- What I did
- How I did it
NOTE: put methods will always set isBinary=true in the update, and get methods will always check isBinary=true in the metadata. It is legitimate to invoke get() for a binary key value but NOT to invoke getBinary() for a string key value.
- How to verify it
PR contains
iterations of increasing byte array length with random bytes, testing that decoded encoded result matches the original input. And then there are tests that explicitly test repeating sequences of 14, 15, and 16 byte arrays (either side of the 15 bit boundary).
All of these tests will be run as part of this PR pipeline.
- Description for the changelog
support for binary key values