Skip to content

fix: fix cached: prefix in Scan CLI#64

Merged
gkc merged 1 commit intoatsign-foundation:trunkfrom
JeremyTubongbanua:scan
Oct 16, 2022
Merged

fix: fix cached: prefix in Scan CLI#64
gkc merged 1 commit intoatsign-foundation:trunkfrom
JeremyTubongbanua:scan

Conversation

@JeremyTubongbanua
Copy link
Member

What I did

Checked for isCached metadata and prepend cached: to the key name if isCached==true

@JeremyTubongbanua JeremyTubongbanua requested a review from gkc October 13, 2022 15:05
@JeremyTubongbanua JeremyTubongbanua self-assigned this Oct 13, 2022
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkc
Copy link
Contributor

gkc commented Oct 15, 2022

LGTM

@JeremyTubongbanua What's your plan for the scan impl itself?

@JeremyTubongbanua
Copy link
Member Author

LGTM

@JeremyTubongbanua What's your plan for the scan impl itself?

The getAtKeys() method returns a List<AtKey>, I don't think there's much I could do unless I modify the .toString() in AtKey

@gkc
Copy link
Contributor

gkc commented Oct 16, 2022

Yeah it's a bit tricky. Here's the way I think all of this should work: cached should not be a part of the key name. When @bob creates data which they share with @alice, and @alice secondary decides to cache that data (for whatever reason), then I believe there is zero value in prepending 'cached:' to the key name, since the very fact that @bob-owned data is stored on @alice's secondary shows that it is cached.

@nickelskevin what do you think about this? This is relevant given our recent & ongoing conversation about overhauling caching behaviour generally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants