Specify in README that it won't do historical data#37
Open
williamcodes wants to merge 1 commit intoattack:masterfrom
Open
Specify in README that it won't do historical data#37williamcodes wants to merge 1 commit intoattack:masterfrom
williamcodes wants to merge 1 commit intoattack:masterfrom
Conversation
I spent 2 hours on this gem wondering why it kept returning nil. If supporting historical temperatures isn't a feature and isn't on the roadmap, that should be super clear in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent 2 hours on this gem wondering why it kept returning nil. If supporting historical temperatures isn't a feature and isn't on the roadmap, that should be super clear in the README.