Fix signer handler #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signer handler was checking if the account name contains a '/' character even though a public key was passed, resulting impossible to request a sign using public keys.
Merged
Contributor
|
Thank you for this report and patch. This has shown up some weaknesses in our testing and other occurrences of this issue, so I have created an alternative PR at #76 that incorporates more fixes and testing. Please could you take a look at this to confirm that it addresses your issue? |
Author
|
That one seems to be working too. |
Contributor
|
Thanks. #76 has been merged so now closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signer handler was checking if the account name contains a
'/'character even though a public key was passed, resulting impossible to request a sign using public keys.