Fix PHPStan analysis errors #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactors middleware definitions to resolve undefined method calls. - The middleware logic was moved from controller constructors to the route definitions in routes/web.php, which is the modern and correct approach in Laravel. - Corrects an inaccurate PHPDoc in the CheckRole middleware. These changes resolve all errors reported by the phpstan analyse command.
Adds a new section to AGENTS.md to instruct agents not to run tests unless specifically asked by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This submission fixes three errors reported by the PHPStan static analysis tool.
Undefined method
middleware()inUserControllerandSuggestionController: The calls to$this->middleware()were removed from the constructors of these controllers. This method of defining middleware in constructors is deprecated. The middleware was already correctly applied to theUserControllerroutes, and was added to theSuggestionControllerroutes.Incorrect PHPDoc in
CheckRolemiddleware: The PHPDoc for thehandlemethod was corrected to properly document the variadic...$rolesparameter.