feat: Support Harmony format responses#2
Merged
auctumnus merged 1 commit intoauctumnus:mainfrom Nov 6, 2025
Merged
Conversation
Owner
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Info
Some models like gpt-oss format their responses using a standard called Harmony, this PR just lets
pleasegrab the final shell command out of the harmony response. I also had to change the prompt a bit to clarify how to format the shell command in the response, and also reiterate the importance of sticking to the json format defined by the request body. I'm not sure how much of a problem it was with models like claude but my gpt-oss instance kept forgetting to do both.Dev notes
I can see regression testing this going forward being annoying since you need access to a harmony model but like ¯_(ツ)_/¯
Screenshots