#16 added std::wstring support for filename.

[andreprager]

linked to issue: problem reading utf8 filenames on windows

[maxmarsc]

Hi, thanks for the contribution and the bug hunt, sorry it took us so long to review it.

Unfortunately the linux build seems to be broken (we should definitively add CI for linux build). We don't have time to investigate right now but here is the error :

Scanning dependencies of target wave
[ 47%] Building CXX object src/wave/CMakeFiles/wave.dir/header/data_header.cc.o
[ 52%] Building CXX object src/wave/CMakeFiles/wave.dir/header/riff_header.cc.o
[ 57%] Building CXX object src/wave/CMakeFiles/wave.dir/header/fmt_header.cc.o
[ 63%] Building CXX object src/wave/CMakeFiles/wave.dir/header/wave_header.cc.o
[ 68%] Building CXX object src/wave/CMakeFiles/wave.dir/header.cc.o
[ 73%] Building CXX object src/wave/CMakeFiles/wave.dir/header_list.cc.o
.../wave/src/wave/header_list.cc: In member function ‘wave::Error wave::HeaderList::Init(const wstring&)’:
.../wave/src/wave/header_list.cc:45:38: error: no matching function for call to ‘std::basic_ifstream<char>::open(const wstring&, const openmode&)’
   stream_.open(path, std::ios::binary);
                                      ^
In file included from .../wave/src/wave/header_list.h:4:0,
                 from .../wave/src/wave/header_list.cc:1:
/usr/include/c++/7/fstream:595:7: note: candidate: void std::basic_ifstream<_CharT, _Traits>::open(const char*, std::ios_base::openmode) [with _CharT = char; _Traits = std::char_traits<char>; std::ios_base::openmode = std::_Ios_Openmode]
       open(const char* __s, ios_base::openmode __mode = ios_base::in)
       ^~~~
/usr/include/c++/7/fstream:595:7: note:   no known conversion for argument 1 from ‘const wstring {aka const std::__cxx11::basic_string<wchar_t>}’ to ‘const char*’
/usr/include/c++/7/fstream:615:7: note: candidate: void std::basic_ifstream<_CharT, _Traits>::open(const string&, std::ios_base::openmode) [with _CharT = char; _Traits = std::char_traits<char>; std::__cxx11::string = std::__cxx11::basic_string<char>; std::ios_base::openmode = std::_Ios_Openmode]
       open(const std::string& __s, ios_base::openmode __mode = ios_base::in)
       ^~~~
/usr/include/c++/7/fstream:615:7: note:   no known conversion for argument 1 from ‘const wstring {aka const std::__cxx11::basic_string<wchar_t>}’ to ‘const string& {aka const std::__cxx11::basic_string<char>&}’
src/wave/CMakeFiles/wave.dir/build.make:127: recipe for target 'src/wave/CMakeFiles/wave.dir/header_list.cc.o' failed
make[2]: *** [src/wave/CMakeFiles/wave.dir/header_list.cc.o] Error 1
CMakeFiles/Makefile2:1081: recipe for target 'src/wave/CMakeFiles/wave.dir/all' failed
make[1]: *** [src/wave/CMakeFiles/wave.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

If you can build on linux please try to fix it, otherwise tell us and we'll try to look into it when we have the time.

Furthermore, please add some tests of your new methods :

• new File constructor should be tested in src/wave/file_test.cc
• new Header Init method should be tested in src/wave/header_test.cc

[andreprager]

It seems the std::wstring interface for std::istream is an extension of MSVC, I will check for a workaround.