Clean up redundant INFOPLIST_KEY_ build settings in project.yml

[auerbachb]

Context

ios/project.yml has several INFOPLIST_KEY_* build settings that are redundant because the project uses a pre-existing Info.plist file. XcodeGen merges info.properties into the plist directly — the INFOPLIST_KEY_ build settings are only effective when Xcode generates the plist from scratch.

These were discovered during the TestFlight pipeline work (PRs #52-56) when iPad validation kept failing despite the build settings being present.

What needs to happen

Remove these redundant settings from project.yml settings.base:

• INFOPLIST_KEY_UIApplicationSceneManifest_Generation
• INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents
• INFOPLIST_KEY_UILaunchScreen_Generation
• INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad
• INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone

Verify these are already covered by the info.properties entries or the raw Info.plist, then remove the dead settings.

Acceptance criteria

• Redundant INFOPLIST_KEY_* settings removed from project.yml
• App still builds and runs correctly
• TestFlight upload still succeeds

[github-actions]

@coderabbitai plan

[coderabbitai]

🔗 Related PRs

#52 - Add TestFlight CI/CD workflow and update signing config [merged]
#56 - Fix iPad validation via XcodeGen info.properties [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[coderabbitai]

Coding Plan

Summary

• Remove five ineffective INFOPLIST_KEY_* build settings that don't work with pre-existing Info.plist files
• The equivalent configuration already exists in info.properties for launch screen and orientation settings
• SwiftUI @main apps don't require an explicit UIApplicationSceneManifest, making that setting unnecessary
• This is a configuration cleanup with no functional changes to app behavior

Design Choices

Design Choice 1: Should `UIApplicationSupportsIndirectInputEvents` be preserved via `info.properties`?

Options Considered:

1. Simply remove the build setting without adding to info.properties (trackpad support remains absent, matching current effective behavior)
2. Add UIApplicationSupportsIndirectInputEvents: true to info.properties while removing the build setting (enables trackpad support)

Chosen Option: 1

Rationale: The build setting was already ineffective, so removing it doesn't change behavior. Adding new functionality is out of scope for this cleanup ticket; if trackpad support is desired, it should be a separate enhancement.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Remove Redundant Build Settings and Validate

This phase removes the ineffective INFOPLIST_KEY_* settings from the XcodeGen configuration and confirms the equivalent functionality is already present via info.properties.

Task 1: Verify Coverage in info.properties

Confirm that each setting being removed is either already covered by info.properties or intentionally unnecessary before deletion.

• Verify UILaunchScreen is in info.properties (already present as UILaunchScreen: {})
• Verify UISupportedInterfaceOrientations is in info.properties (already present with orientation arrays)
• Verify UISupportedInterfaceOrientations~ipad is in info.properties (already present with orientation arrays)
• Confirm UIApplicationSceneManifest is not needed for SwiftUI @main apps on iOS 14+ (SwiftUI manages scenes internally)
• Acknowledge UIApplicationSupportsIndirectInputEvents will remain absent (acceptable—was already ineffective)

Task 2: Remove Redundant Settings from project.yml

Remove the five INFOPLIST_KEY_* entries from the settings.base section of ios/project.yml.

• Update ios/project.yml to remove INFOPLIST_KEY_UIApplicationSceneManifest_Generation
• Update ios/project.yml to remove INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents
• Update ios/project.yml to remove INFOPLIST_KEY_UILaunchScreen_Generation
• Update ios/project.yml to remove INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad
• Update ios/project.yml to remove INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone
• Keep all other settings in settings.base unchanged (PRODUCT_BUNDLE_IDENTIFIER, MARKETING_VERSION, etc.)

Task 3: Regenerate Xcode Project and Validate Build

Regenerate the Xcode project from the updated configuration and verify the app builds correctly.

• Run xcodegen generate from the ios/ directory to regenerate StillPoint.xcodeproj
• Build the app for both iPhone and iPad simulators to confirm no build errors
• Run the app on a simulator to verify basic functionality
• Optionally, perform a TestFlight archive build to confirm the validation pipeline still succeeds

🤖 Prompt for AI agents

This phase removes five redundant `INFOPLIST_KEY_*` build settings from
`ios/project.yml` and validates that equivalent configuration is already handled
via `info.properties`.

**Task 1 – Verify coverage in `info.properties` (no code changes, verification
only):**
- Confirm `UILaunchScreen` is present in `info.properties` (expected value:
`UILaunchScreen: {}`)
- Confirm `UISupportedInterfaceOrientations` is present in `info.properties`
(with orientation arrays)
- Confirm `UISupportedInterfaceOrientations~ipad` is present in
`info.properties` (with orientation arrays)
- Note that `UIApplicationSceneManifest` is not required for SwiftUI `@main`
apps on iOS 14+ (SwiftUI manages scenes internally)
- Note that `UIApplicationSupportsIndirectInputEvents` will intentionally remain
absent, as it was already ineffective

**Task 2 – Edit `ios/project.yml`:**
- Locate the `settings.base` section
- Remove the following five keys entirely:
  - `INFOPLIST_KEY_UIApplicationSceneManifest_Generation`
  - `INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents`
  - `INFOPLIST_KEY_UILaunchScreen_Generation`
  - `INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad`
  - `INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone`
- Leave all other keys in `settings.base` (e.g., `PRODUCT_BUNDLE_IDENTIFIER`,
`MARKETING_VERSION`) completely unchanged

**Task 3 – Regenerate and validate (commands, no code changes):**
- Run `xcodegen generate` from the `ios/` directory to regenerate
`StillPoint.xcodeproj`
- Build for both iPhone and iPad simulators to confirm no build errors
- Run the app on a simulator to verify basic functionality
- Optionally perform a TestFlight archive build to confirm the validation
pipeline still succeeds

Research

The iOS app is built using XcodeGen with configuration in ios/project.yml. The project uses a pre-existing ios/StillPointApp/Info.plist file that XcodeGen merges with inline info.properties entries. The app uses a pure SwiftUI @main lifecycle (no UIKit AppDelegate/SceneDelegate). The INFOPLIST_KEY_* build settings in settings.base were intended to inject plist values at build time, but this approach doesn't work reliably with pre-existing plist files—XcodeGen's info.properties is the correct mechanism for this project.

---

🚀 Next Steps

🤖 All AI agent prompts combined

This phase removes five redundant `INFOPLIST_KEY_*` build settings from
`ios/project.yml` and validates that equivalent configuration is already handled
via `info.properties`.

**Task 1 – Verify coverage in `info.properties` (no code changes, verification
only):**
- Confirm `UILaunchScreen` is present in `info.properties` (expected value:
`UILaunchScreen: {}`)
- Confirm `UISupportedInterfaceOrientations` is present in `info.properties`
(with orientation arrays)
- Confirm `UISupportedInterfaceOrientations~ipad` is present in
`info.properties` (with orientation arrays)
- Note that `UIApplicationSceneManifest` is not required for SwiftUI `@main`
apps on iOS 14+ (SwiftUI manages scenes internally)
- Note that `UIApplicationSupportsIndirectInputEvents` will intentionally remain
absent, as it was already ineffective

**Task 2 – Edit `ios/project.yml`:**
- Locate the `settings.base` section
- Remove the following five keys entirely:
  - `INFOPLIST_KEY_UIApplicationSceneManifest_Generation`
  - `INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents`
  - `INFOPLIST_KEY_UILaunchScreen_Generation`
  - `INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad`
  - `INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone`
- Leave all other keys in `settings.base` (e.g., `PRODUCT_BUNDLE_IDENTIFIER`,
`MARKETING_VERSION`) completely unchanged

**Task 3 – Regenerate and validate (commands, no code changes):**
- Run `xcodegen generate` from the `ios/` directory to regenerate
`StillPoint.xcodeproj`
- Build for both iPhone and iPad simulators to confirm no build errors
- Run the app on a simulator to verify basic functionality
- Optionally perform a TestFlight archive build to confirm the validation
pipeline still succeeds

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!