fix: No thought-capture prompt after light distraction hold#198
Conversation
Light-distraction hold exits now only log awareness segments instead of auto-offering thought capture. Updated web and iOS helper text to clarify that captured notes require explicit capture flows. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 38 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoved the implicit post-distraction thought-capture trigger from hold-finalization paths and introduced an explicit capture action. Finalization APIs were simplified (parameter removed) and callers updated; a new explicit "openThoughtCapture" / "capture" affordance was added and UI text adjusted to state that light-distraction holds only log segments. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6a06211. Configure here.
Remove dead hold-finalization capture flags and add explicit capture-note actions on web and iOS so thought capture is intentional rather than tied to light-distraction release. Made-with: Cursor
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ios/StillPointApp/ViewModels/SessionViewModel.swift`:
- Line 139: The call to finalizeActiveHoldIfNeeded(at:elapsed,
offerThoughtCapture: false) prevents showPostDistractionCapture from ever being
set, making the post-hold thought-capture UI unreachable; either restore passing
offerThoughtCapture: true on the paths that should trigger post-hold capture or
add an explicit method (e.g., setShowPostDistractionCapture(true) or
offerPostHoldCapture()) invoked after finalizeActiveHoldIfNeeded in the
appropriate hold-completion branches so that the showPostDistractionCapture flag
(and any related UI state) is toggled when intended; update references in
SessionViewModel where finalizeActiveHoldIfNeeded(...) is called to ensure the
intended behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c1e4c0c4-8e1d-4f28-a04b-ea924334e02d
📒 Files selected for processing (4)
ios/StillPointApp/ViewModels/SessionViewModel.swiftios/StillPointApp/Views/SessionView.swiftsrc/components/BuddySessionRoom.tsxsrc/components/SessionView.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ios/StillPointApp/ViewModels/SessionViewModel.swift`:
- Around line 157-160: The capture action is blocked by the isActive guard in
openThoughtCapture(), causing a dead tappable button; remove the guard and let
openThoughtCapture() always call finalizeActiveHoldIfNeeded(at: elapsed) and set
showPostDistractionCapture = true so the capture flow works whether the session
is active or paused. Locate the openThoughtCapture() method and replace the
current guarded return logic with an unconditional call to
finalizeActiveHoldIfNeeded(at: elapsed) followed by setting
showPostDistractionCapture = true so the UI button becomes effective in paused
state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0e389142-3e19-4636-a2c0-fb8b49adf284
📒 Files selected for processing (4)
ios/StillPointApp/ViewModels/SessionViewModel.swiftios/StillPointApp/Views/SessionView.swiftsrc/components/BuddySessionRoom.tsxsrc/components/SessionView.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/SessionView.tsx
Enable the iOS capture action when a session is paused so the Capture button is not a no-op, while still guarding against completed or abandoned sessions. Made-with: Cursor
Made-with: Cursor
1 participant
Summary
Closes #187
Test Plan
SessionViewdoes not open post-segment thought capture.BuddySessionRoomdoes not open post-segment thought capture.ThoughtCaptureView/post-hold capture overlay.Made with Cursor
Summary by CodeRabbit
New Features
Changes
Documentation