Fix iOS auth archive error and bump build 8#245
Conversation
Co-authored-by: Bretton Auerbach <auerbachb@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR increments the iOS build number from 7 to 8 (project config and docs) and adds explicit error assignment and logging in AuthViewModel catch paths for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
ios/RELEASING.md (1)
65-65: Consider using a generic “next build” example to reduce doc churn.This is valid now, but using a placeholder (e.g.,
ios-v<marketing-version>-build<next-build>) can prevent future stale copy/paste mistakes.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ios/RELEASING.md` at line 65, Replace the concrete example "ios-v1.0.3-build8" with a generic placeholder to avoid stale copy/paste; update the sentence to use a template like "ios-v<marketing-version>-build<next-build>" so readers are guided to substitute their marketing version and the next build number rather than copying a fixed example.ios/StillPointApp/ViewModels/AuthViewModel.swift (1)
48-50: Consider logging caught errors for debugging.The actual caught error is discarded here (and similarly at line 72-74). While the generic user-facing message is appropriate for UX, consider logging the underlying error to aid debugging production issues, for example:
} catch { print("Auth error: \(error.localizedDescription)") self.error = "Connection failed. Please try again." return nil }This would preserve the user-friendly message while capturing diagnostic information.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ios/StillPointApp/ViewModels/AuthViewModel.swift` around lines 48 - 50, In AuthViewModel, in the catch blocks that currently set self.error = "Connection failed. Please try again." and return nil, log the caught error before overwriting it (e.g., use print or your app logger with error.localizedDescription or the Error itself) so diagnostic details are preserved; apply this change to both catch sites (the ones that set self.error and return nil) so user-facing messages remain the same but underlying exceptions are recorded for debugging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ios/RELEASING.md`:
- Line 65: Replace the concrete example "ios-v1.0.3-build8" with a generic
placeholder to avoid stale copy/paste; update the sentence to use a template
like "ios-v<marketing-version>-build<next-build>" so readers are guided to
substitute their marketing version and the next build number rather than copying
a fixed example.
In `@ios/StillPointApp/ViewModels/AuthViewModel.swift`:
- Around line 48-50: In AuthViewModel, in the catch blocks that currently set
self.error = "Connection failed. Please try again." and return nil, log the
caught error before overwriting it (e.g., use print or your app logger with
error.localizedDescription or the Error itself) so diagnostic details are
preserved; apply this change to both catch sites (the ones that set self.error
and return nil) so user-facing messages remain the same but underlying
exceptions are recorded for debugging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0f2d5968-2572-4b86-85c9-912e7f44a6b7
📒 Files selected for processing (4)
ios/QA_CHECKLIST.mdios/RELEASING.mdios/StillPointApp/ViewModels/AuthViewModel.swiftios/project.yml
Co-authored-by: Bretton Auerbach <auerbachb@users.noreply.github.com>
Summary
AuthViewModelby disambiguating assignment to the view-modelerrorproperty insidecatch.1.0.3 (7)to1.0.3 (8)and document the next TestFlight tag asios-v1.0.3-build8becauseios-v1.0.3-build7failed before upload.ios/RELEASING.mdand logging underlying auth/reset exceptions before setting user-facing messages.Testing
git diff --checkios/project.yml,ios/QA_CHECKLIST.md, andios/RELEASING.mdagree on build 8 /ios-v1.0.3-build8.ios-v1.0.3-build7; workflow failed during archive before upload with the compile error fixed here.Summary by CodeRabbit
Chores
Refactor