Skip to content

Fix iOS auth archive error and bump build 8#245

Merged
auerbachb merged 2 commits into
mainfrom
cursor/fix-ios-build8-auth-archive-56a8
Apr 27, 2026
Merged

Fix iOS auth archive error and bump build 8#245
auerbachb merged 2 commits into
mainfrom
cursor/fix-ios-build8-auth-archive-56a8

Conversation

@auerbachb
Copy link
Copy Markdown
Owner

@auerbachb auerbachb commented Apr 27, 2026

Summary

  • Fix the iOS archive compile error in AuthViewModel by disambiguating assignment to the view-model error property inside catch.
  • Bump the iOS release candidate from 1.0.3 (7) to 1.0.3 (8) and document the next TestFlight tag as ios-v1.0.3-build8 because ios-v1.0.3-build7 failed before upload.
  • Address review feedback by using a generic re-upload tag template in ios/RELEASING.md and logging underlying auth/reset exceptions before setting user-facing messages.

Testing

  • git diff --check
  • Validated ios/project.yml, ios/QA_CHECKLIST.md, and ios/RELEASING.md agree on build 8 / ios-v1.0.3-build8.
  • Validated the generic release tag example and auth error logging changes.
  • Attempted TestFlight tag ios-v1.0.3-build7; workflow failed during archive before upload with the compile error fixed here.
Open in Web Open in Cursor 

Summary by CodeRabbit

  • Chores

    • Bumped iOS build number (build 8) and updated release/QA documentation and release examples for TestFlight.
  • Refactor

    • Improved authentication error handling to log unexpected errors more clearly, aiding diagnostics.

Co-authored-by: Bretton Auerbach <auerbachb@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
still-point Ignored Ignored Preview Apr 27, 2026 5:12pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 948dc1fc-a70b-47f2-bcb1-54548c0807de

📥 Commits

Reviewing files that changed from the base of the PR and between 8733a68 and a7cf72f.

📒 Files selected for processing (2)
  • ios/RELEASING.md
  • ios/StillPointApp/ViewModels/AuthViewModel.swift
🚧 Files skipped from review as they are similar to previous changes (2)
  • ios/StillPointApp/ViewModels/AuthViewModel.swift
  • ios/RELEASING.md

📝 Walkthrough

Walkthrough

This PR increments the iOS build number from 7 to 8 (project config and docs) and adds explicit error assignment and logging in AuthViewModel catch paths for submit() and requestPasswordReset().

Changes

Cohort / File(s) Summary
iOS Build Version Bump
ios/project.yml, ios/QA_CHECKLIST.md, ios/RELEASING.md
Bumps CURRENT_PROJECT_VERSION from 7 to 8; updates documented release candidate, example commit/tag names, and replaces a hard-coded re-upload tag with a placeholder-based tag format.
AuthViewModel Error Handling
ios/StillPointApp/ViewModels/AuthViewModel.swift
In submit() and requestPasswordReset(), generic catch now logs error.localizedDescription and assigns to self.error (instead of an unqualified error).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐇 I hopped through code, with tiny cheer,

Bumped a build — now eight is here.
Docs aligned and logs set free,
Errors named as clear as can be.
A little rabbit clap for release glee!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix iOS auth archive error and bump build 8' accurately summarizes the two main changes in the pull request: fixing an auth compilation error and bumping the build number.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-ios-build8-auth-archive-56a8

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
ios/RELEASING.md (1)

65-65: Consider using a generic “next build” example to reduce doc churn.

This is valid now, but using a placeholder (e.g., ios-v<marketing-version>-build<next-build>) can prevent future stale copy/paste mistakes.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ios/RELEASING.md` at line 65, Replace the concrete example
"ios-v1.0.3-build8" with a generic placeholder to avoid stale copy/paste; update
the sentence to use a template like "ios-v<marketing-version>-build<next-build>"
so readers are guided to substitute their marketing version and the next build
number rather than copying a fixed example.
ios/StillPointApp/ViewModels/AuthViewModel.swift (1)

48-50: Consider logging caught errors for debugging.

The actual caught error is discarded here (and similarly at line 72-74). While the generic user-facing message is appropriate for UX, consider logging the underlying error to aid debugging production issues, for example:

} catch {
    print("Auth error: \(error.localizedDescription)")
    self.error = "Connection failed. Please try again."
    return nil
}

This would preserve the user-friendly message while capturing diagnostic information.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ios/StillPointApp/ViewModels/AuthViewModel.swift` around lines 48 - 50, In
AuthViewModel, in the catch blocks that currently set self.error = "Connection
failed. Please try again." and return nil, log the caught error before
overwriting it (e.g., use print or your app logger with
error.localizedDescription or the Error itself) so diagnostic details are
preserved; apply this change to both catch sites (the ones that set self.error
and return nil) so user-facing messages remain the same but underlying
exceptions are recorded for debugging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@ios/RELEASING.md`:
- Line 65: Replace the concrete example "ios-v1.0.3-build8" with a generic
placeholder to avoid stale copy/paste; update the sentence to use a template
like "ios-v<marketing-version>-build<next-build>" so readers are guided to
substitute their marketing version and the next build number rather than copying
a fixed example.

In `@ios/StillPointApp/ViewModels/AuthViewModel.swift`:
- Around line 48-50: In AuthViewModel, in the catch blocks that currently set
self.error = "Connection failed. Please try again." and return nil, log the
caught error before overwriting it (e.g., use print or your app logger with
error.localizedDescription or the Error itself) so diagnostic details are
preserved; apply this change to both catch sites (the ones that set self.error
and return nil) so user-facing messages remain the same but underlying
exceptions are recorded for debugging.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0f2d5968-2572-4b86-85c9-912e7f44a6b7

📥 Commits

Reviewing files that changed from the base of the PR and between 5f7a0bc and 8733a68.

📒 Files selected for processing (4)
  • ios/QA_CHECKLIST.md
  • ios/RELEASING.md
  • ios/StillPointApp/ViewModels/AuthViewModel.swift
  • ios/project.yml

Co-authored-by: Bretton Auerbach <auerbachb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants