CompletionView: make Save Note button a full-width green capsule#43
Conversation
Replace the small green text link with a prominent full-width capsule button matching the app's design language. The button has three states: - Disabled/muted when text field is empty (surface2 bg, fg3 text) - Active green capsule when text is entered (SPColor.green bg, dark text) - Disabled Saved state after saving (returns to muted appearance) Uses the same serifItalic(18), Capsule(), and spacing as the Return button for visual consistency. Closes #32
- Add isSaveDisabled computed property to replace repeated condition - Add .onChange(of: endNote) to clear noteSaved when user edits text, allowing re-saving after editing
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Save Note button in CompletionView was refactored to use centralized state management. A new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
isSaveDisabledcomputed property for clean conditional logic.onChange(of: endNote)to reset saved state when user edits text, enabling re-savingButton States
Test plan
Closes #32
Summary by CodeRabbit