Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
The changes made: added code to sort the raw data and add them into a text file.
What did you learn from the changes you have made?
I learned how to sort raw data.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
There was no other approach that I thought about making.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had an issue with acquiring the data from the zip file. I overcame this by reaching out to the DSI team for help. Vishnou suggested that "there is something with [my] machine that prevents the download (certificate issue)" and he provided me with an alternative code for the line with the curl command.
I also had received some errors when trying to move the files from one directory to the new one that was created as well as some permission issues that arose when trying to move files from one directory to another. I overcame the move errors by going over my script and realizing that there were some typos, mistakenly wrote "mkdir" instead of "mv" on one line. I also started the process over a few times to make sure that the correct directories and sub-directories were being created.
I also pushed to the wrong branch (DSI) because I was not aware that we had to select & verify the branches at the top of this page. I had to ask ChatGPT for an explanation on forking to make sure I understood it correctly. I
How were these changes tested?
I tested the changes by moving into the respective directories and checking their contents.
A reference to a related issue in your repository (if applicable)
Checklist