Closed
Conversation
Owner
|
It's a bug that Proxy is in scope without being imported. |
Owner
|
The Prelude mistakingly re-exported Data.Records. Fixed 52f0cc7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Proxyis automatically imported (it's reexported byData.Records, which is reexported byMhs.Builtin). This is a problem when defining your own type calledProxy, as is the case in the pipes library.To fix this, I tried to get rid of all
Proxyusages inData.Records. However, with this PR, building mhs currently fails (which is why this is a draft PR) with the following error:The code in question is
I'm not sure what causes this error, although changing the kind signature of
HasFieldandSetFieldto useSymbolinstead ofk :: Kindseems to fix it (this would be a departure from how GHC does it though).