Fix almost all Hugs incompatibilities#429
Open
AlexandreTunstall wants to merge 9 commits intoaugustss:masterfrom
Open
Fix almost all Hugs incompatibilities#429AlexandreTunstall wants to merge 9 commits intoaugustss:masterfrom
AlexandreTunstall wants to merge 9 commits intoaugustss:masterfrom
Conversation
13 tasks
AlexandreTunstall
force-pushed
the
hfs-hugs-head
branch
from
afae6cc to
04e14a2
Compare
Contributor
Author
|
One other noteworthy issue that this PR doesn't address is the inability to compile the |
SetTCState requires a cyclic import, which Hugs doesn't support. With a bit of tweaking, it is possible to replace all uses of SetTCState with slightly less hacky code.
AlexandreTunstall
force-pushed
the
hfs-hugs-head
branch
from
04e14a2 to
1678496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only thing this PR doesn't fix is the use of patterns that Hugs cannot parse (
ViewPatternsand commas in guards).I do have a patch for the incompatible patterns, but it involves a lot of
isJustandfromJustso I have omitted it here.Please let me know if you're interested in that change despite its flaws.
I tested this against
v0.15.4.0and then rebased the fixes ontomaster, so this doesn't address any incompatibilities added tomastersincev0.15.4.0.