fix(callAPIMethod): bug ff & safari

[ya-woodcutter]

ff & safari (isomorphic-fetch) doesn't support response.body

[coveralls]

Coverage decreased (-1.7%) to 98.333% when pulling 6b68d1f on ya-woodcutter:fix-ff-safari into 4f0ffda on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling a03047b on ya-woodcutter:fix-ff-safari into 4f0ffda on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling a03047b on ya-woodcutter:fix-ff-safari into 4f0ffda on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling a03047b on ya-woodcutter:fix-ff-safari into 4f0ffda on auru:master.

[TimeRaider]

@ya-woodcutter according to https://developer.mozilla.org/en-US/docs/Web/API/Response
Response implements Body. I think the issue is with isomorphic-fetch not being really isomorphic and using node-fetch underneath.
Did you try using Response.blob() instead?

const promiseCallback =  result[result.body ? method : 'blob']();

[ya-woodcutter]

I think the issue is with isomorphic-fetch not being really isomorphic...

Isomorphic-fetch implements the minimal functionality of fetch.

Did you try using Response.blob() instead?

I didn't try to do it. But I think that the transform data from Blob to the right data type will be problematic. It requires additional conditions.

I'll try to do something in this way.

[coveralls]

Coverage remained the same at 100.0% when pulling 19a4b6f on ya-woodcutter:fix-ff-safari into 4f0ffda on auru:master.

[ya-woodcutter]

Now:

• We are trying to call response[method]()
• First catch:
  • if !ok then throw new Error(status, statusText)
  • if ok then return body || null (If we are in this catch, then an error in getting data)
• Then:
  • if !ok then throw new Error(status, statusText, body)
  • if ok then return body
• Second catch: return error

[TimeRaider]

@ya-woodcutter Sorry I've fucked up your pr

[ya-woodcutter]

@TimeRaider ? emm... it's ok :)

[coveralls]

Coverage remained the same at 100.0% when pulling f6c360a on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling f6c360a on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling f6c360a on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling d9e87b8 on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling ec4e3af on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling ec4e3af on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[ya-woodcutter]

UP: @TimeRaider @evilj0e @Blackheart340

[Blackheart340]

Let's keep the same codestyle everywhere

[coveralls]

Coverage remained the same at 100.0% when pulling c67fc56 on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling c67fc56 on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.

[coveralls]

Coverage remained the same at 100.0% when pulling c67fc56 on ya-woodcutter:fix-ff-safari into 0d946d1 on auru:master.