chore: modernize to newer vscode/tsc#60
Open
Artoria2e5 wants to merge 9 commits intoaustin-----:masterfrom
Open
chore: modernize to newer vscode/tsc#60Artoria2e5 wants to merge 9 commits intoaustin-----:masterfrom
Artoria2e5 wants to merge 9 commits intoaustin-----:masterfrom
Conversation
Going through the shall has many consequences including the strange inconsistent quoting required. We can just choose to not do that.
Contributor
Author
|
Apologies for the extra changes. I was trying to get it to work on my copy of global (msys2) ASAP, so these things got mixed together... May I ask whether you have tested it after refactoring the lineReader thing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now compiles on typescript 3