Open
Conversation
- Added `parseEditorArgs` function for Windows and POSIX systems to handle command line arguments for text editors. - Created `editor_windows.go` and `editor_unix.go` files to separate platform-specific implementations. - Introduced tests in `editor_windows_test.go` and `editor_unix_test.go` to ensure correct parsing behavior across different scenarios. - This change enhances compatibility with various text editors by correctly interpreting command line arguments, improving user experience.
- Clarified the default text editor settings for Linux/macOS and Windows. - Added examples for setting the `EDITOR` environment variable in PowerShell and Command Prompt on Windows. - Ensured instructions are clear for both terminal and non-terminal editors.
- Updated the Notepad++ and Visual Studio Code paths to a more generic format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adds platform-specific argument parsing for the
EDITORenvironment variable to allow setting default on Windows.CommandLineToArgvWAPI to correctly handle backslash paths and quoted paths with spacesgo-shellquotefor POSIX shell quotingeditor_windows.go,editor_unix.go)README updates:
vimon Linux/macOS,notepadon Windows)EDITORin PowerShell and Command Prompt📚 References
🔬 Testing
Automated tests added for both platforms covering:
Manual testing performed on a Windows machine:
📝 Checklist