Skip to content

Extract authorities from permissions claim#40

Merged
jimmyjames merged 2 commits intoauth0:masterfrom
jimmyjames:authorities-from-permissions-claim
Jan 30, 2020
Merged

Extract authorities from permissions claim#40
jimmyjames merged 2 commits intoauth0:masterfrom
jimmyjames:authorities-from-permissions-claim

Conversation

@jimmyjames
Copy link
Copy Markdown
Contributor

Changes

Closes #36

  • Extract authorities from permissions claims
  • Prefix scope authorities with SCOPE_, permissions authorities with PERMISSION_
  • Keep un-prefixed scope authorities for backwards-compatibility

This change does not include the ability to specify a custom claim to create authorities from.

References

#36

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames jimmyjames added CH: Added small Small review labels Jan 23, 2020
@jimmyjames jimmyjames added this to the v1-Next milestone Jan 23, 2020
Co-Authored-By: Luciano Balmaceda <balmacedaluciano@gmail.com>
@jimmyjames jimmyjames marked this pull request as ready for review January 24, 2020 23:30
@jimmyjames jimmyjames requested a review from a team January 24, 2020 23:30
@joshcanhelp joshcanhelp removed the request for review from a team January 27, 2020 21:25
@jimmyjames jimmyjames requested a review from lbalmaceda January 28, 2020 03:29
@jimmyjames jimmyjames merged commit fd3236e into auth0:master Jan 30, 2020
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.2.7, 1.3.0 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CH: Added small Small review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permissions support

3 participants