Skip to content

Expose public API dependencies as api scope and update versions#45

Merged
jimmyjames merged 1 commit intoauth0:masterfrom
jimmyjames:fix-dependency-scopes
Apr 13, 2020
Merged

Expose public API dependencies as api scope and update versions#45
jimmyjames merged 1 commit intoauth0:masterfrom
jimmyjames:fix-dependency-scopes

Conversation

@jimmyjames
Copy link
Copy Markdown
Contributor

Changes

Makes the following dependencies available to use through transitive dependencies, which are used by the public API of this library:

  • com.auth0:java-jwt
  • com.auth0:jwks-rsa
  • org.springframework.security:spring-security-core
  • org.springframework.security:spring-security-web
  • org.springframework.security:spring-security-config

Also makes the following changes:

  • Updates the dependency versions to the latest minor/patch releases available.
  • Clarifies the targeted Spring versions for this library

Fixes #44 and #43

References

Gradle dependency scopes

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames jimmyjames added CH: Fixed tiny Tiny review documentation This adds, fixes or improves documentation labels Apr 13, 2020
@jimmyjames jimmyjames added this to the v1-Next milestone Apr 13, 2020
@jimmyjames jimmyjames requested a review from a team April 13, 2020 22:41
Copy link
Copy Markdown

@Jazzepi Jazzepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding the note about spring boot 2 ;P

@jimmyjames
Copy link
Copy Markdown
Contributor Author

jimmyjames commented Apr 13, 2020

Thanks for your engagement @Jazzepi! Will get this released this week and follow-up here when it's available 👍

@jimmyjames jimmyjames merged commit 86eabe2 into auth0:master Apr 13, 2020
@Jazzepi
Copy link
Copy Markdown

Jazzepi commented Apr 14, 2020

@jimmyjames I don't know what your company structure is like, but you may want to look at any project that's based off of gradle. My impression is that someone went through that committed changes to move from the old gradle dependency keywords to the new ones (api/implementation/compileOnly, etc) and mapped a few to api they shouldn't have. Probably while upgrading gradle.

Another project that has the new gradle keywords. https://github.com/auth0/auth0-java/blob/master/build.gradle But these look like it's probably okay that all of them are implementation, but I don't know what other gradle based libraries you guys have.

@maxkramer
Copy link
Copy Markdown

@jimmyjames when can we expect a new release to be cut?

@jimmyjames jimmyjames modified the milestones: v1-Next, 1.3.1 Apr 24, 2020
@jimmyjames jimmyjames deleted the fix-dependency-scopes branch April 24, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CH: Fixed documentation This adds, fixes or improves documentation tiny Tiny review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Published package missing dependencies

4 participants