Expose public API dependencies as api scope and update versions#45
Conversation
…ify targeted Spring versions in README
Jazzepi
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for adding the note about spring boot 2 ;P
|
Thanks for your engagement @Jazzepi! Will get this released this week and follow-up here when it's available 👍 |
|
@jimmyjames I don't know what your company structure is like, but you may want to look at any project that's based off of gradle. My impression is that someone went through that committed changes to move from the old gradle dependency keywords to the new ones (api/implementation/compileOnly, etc) and mapped a few to api they shouldn't have. Probably while upgrading gradle. Another project that has the new gradle keywords. https://github.com/auth0/auth0-java/blob/master/build.gradle But these look like it's probably okay that all of them are implementation, but I don't know what other gradle based libraries you guys have. |
|
@jimmyjames when can we expect a new release to be cut? |
Changes
Makes the following dependencies available to use through transitive dependencies, which are used by the public API of this library:
com.auth0:java-jwtcom.auth0:jwks-rsaorg.springframework.security:spring-security-coreorg.springframework.security:spring-security-weborg.springframework.security:spring-security-configAlso makes the following changes:
Fixes #44 and #43
References
Gradle dependency scopes
Testing
Checklist