Add missing backchannel logout initiators to model type.#794
Closed
dmarjoram wants to merge 1 commit intoauth0:masterfrom
Closed
Add missing backchannel logout initiators to model type.#794dmarjoram wants to merge 1 commit intoauth0:masterfrom
dmarjoram wants to merge 1 commit intoauth0:masterfrom
Conversation
Contributor
|
Hi @dmarjoram 👋 Thanks for taking time and contributing. |
6 tasks
Contributor
|
@dmarjoram |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If a client is configured with a certain backchannel logout initiators, any GetClient calls to the management API using the Auth0 SDK will fail with a serialisation exception.
e.g.
The following will cause failures on the latest Auth0 SDK version:
References
The additions to the enumeration come from https://auth0.com/docs/authenticate/login/logout/back-channel-logout/oidc-back-channel-logout-initiators#selected-initiators-property so this PR ensures all initiators currently documented are supported by the SDK.
Testing
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors