Configure cache with TimeUnit instead of Duration #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poovamraj
approved these changes
Feb 1, 2022
Contributor
poovamraj
left a comment
poovamraj
left a comment
There was a problem hiding this comment.
Looks good 👍 Neat solution.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #136, the introduction of support for
Durationcauses an issue when usingcom.google.guava:guava:30.1.1-android, as the Android version does not support configuration withDuration(the comment here suggests it should be added). In this case we can just invert the constructor delegation ofGuavaCachedJwkProviderto call Guava usingTimeUnit.In my tests using a project with a dependency on
com.google.guava:guava:30.1.1-android, this change fixed the reported issue.