This repository was archived by the owner on Mar 18, 2025. It is now read-only.
feat: make sure hooks are created with the disabled flag always set #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwelveNights
force-pushed
the
ESD-21604-enabled-flag
branch
from
6cb7c5c to
f92dc99
Compare
ggoodman
reviewed
Jun 2, 2023
| onOutput: function (log, build, url) { | ||
| var action = claims ? 'updated' : 'created'; | ||
| var state = args.meta['auth0-extension-disabled'] ? 'disabled' : 'enabled'; | ||
| var state = args.meta['auth0-extension-disabled'] === "1" ? 'disabled' : 'enabled'; |
Contributor
There was a problem hiding this comment.
Might be worth linking to the other side of the 'contract' in a comment: https://github.com/auth0/auth0-ext/blob/b88d38546785cd326f45b4c36e676d240c3b7527/lib/executeExtension2.js#L751-L753
ggoodman
approved these changes
Jun 2, 2023
Contributor
ggoodman
left a comment
ggoodman
left a comment
There was a problem hiding this comment.
These changes LGTM and I'd approve them as-is. That being said, given all these checks for 'is enabled' or 'is disabled' a helper function might be warranted, like isDisabled(meta) to centralize the check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates webtasks with the disabled flag always set.
References
https://auth0team.atlassian.net/browse/ESD-21604
Testing
Checklist
master