Skip to content

fix(security): validate redirect_uri to prevent open redirect attacks#579

Merged
lakhansamani merged 2 commits intomainfrom
fix/open-redirect-validation
Apr 5, 2026
Merged

fix(security): validate redirect_uri to prevent open redirect attacks#579
lakhansamani merged 2 commits intomainfrom
fix/open-redirect-validation

Conversation

@lakhansamani
Copy link
Copy Markdown
Contributor

Summary

  • Login app (CRITICAL): Added isValidRedirectUri() validation in web/app/src/Root.tsx — redirect_uri from URL query params is now validated against same-origin and configured redirect URL before use
  • Protocol validation: Cross-origin redirects only allowed for http: and https: protocols, blocking javascript: and data: URI attacks

Note

Companion PRs needed for SDK repos (authorizer-react, authorizer-svelte, authorizer-vue) with the same isValidRedirectUri() fix in their respective AuthorizerResetPassword components.

Test plan

  • Changes reviewed for correctness
  • Verify login flow redirects work for same-origin URLs
  • Verify cross-origin redirect to evil.com is blocked
  • Verify configured redirect_uri still works

Add isValidRedirectUri() validation in Root.tsx to ensure redirect_uri
from URL query params is validated before use. Only same-origin and
configured redirect URLs are allowed. Blocks javascript: and data: URIs.
@lakhansamani lakhansamani merged commit f8e9b4c into main Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant