Skip to content

Conversation

@Jaspreet-singh-1032
Copy link
Collaborator

Closes #83

Allow users to override the template and subject that is used to send export job completion mail.

Default values:-

Default email subject: "Django: Export job completed"
Default email template: "email/export_job_completion.html"

To override default values override these variables from the Django settings:-

EXPORT_JOB_COMPLETION_MAIL_SUBJECT="Custom subject"
EXPORT_JOB_COMPLETION_MAIL_TEMPLATE="myfolder/custom_template.html"

@Jaspreet-singh-1032
Copy link
Collaborator Author

Hi @timthelion, Please have a look into this PR and let me know if any changes are needed.
Thanks!

@timthelion
Copy link
Member

This looks excellent. Two small issues:

  1. You should add the html2text dependency here as well:

    requires = ["Django", "django-import-export", "django-author"]

  2. It seems you have some flake errors

@Jaspreet-singh-1032
Copy link
Collaborator Author

Sure, will address them.

@timthelion timthelion merged commit 083aafe into auto-mat:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the email sent to user to another language or text.

2 participants