Conversation
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 66.33% 67.15% +0.82%
==========================================
Files 17 17
Lines 1613 1629 +16
==========================================
+ Hits 1070 1094 +24
+ Misses 543 535 -8
Continue to review full report at Codecov.
|
mfeurer
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left a few comments. There's currently one PEP8 issue that would also require your attention. You can check locally by doing pip install pre-commit to install pre-commit, pre-commit installto install all packages required to run the checks (flake8 etc) and finallypre-commit run` to do the checks.
mfeurer
left a comment
There was a problem hiding this comment.
This looks good, thank you. Do you think such casting needs to be applied for the condition statements as well?
convert the corresponding forbidden values correctly to the target hyperparameters type