Conversation
|
Looks good, generally. How come you did not add the argument |
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 66.33% 68.17% +1.83%
==========================================
Files 17 17
Lines 1613 1681 +68
==========================================
+ Hits 1070 1146 +76
+ Misses 543 535 -8
Continue to review full report at Codecov.
|
|
I'm okay with either the current implementation or the pure dict one. In general, as long as |
|
Yes, this is much better than before. I am fine with the current version, but I would prefer something that is actually valid code, i.e. a pure dict, over something that just looks like its valid but is then missing an argument. |
|
I like the dictionary output. |
|
my gut feeling is that most of the community is looking for |
|
I would prefer the current implementation. We need to be aware that the printed object is a configuration, not a dict. |
|
Thanks everyone for your feedback. As we need to balance readability and pastability here I think the current proposal strikes a nice middle ground:
I just also updated the docs and enabled doctests. |
Implements #66.
Configurations are now printed as
opposed to
.
This does not yet allow for copy-pasting the configuration as the argument
configuration_spaceis not printed, but it is much closer. Yet another alternative would bewhich could be used as the
valuesargument toConfiguration.If there are any other suggestions I would be happy to hear about them.
CC @eddiebergman @KEggensperger @dengdifan @renesass @mlindauer @RaghuSpaceRajan