Skip to content

Fixes equality with ordering of hyperparameters#212

Merged
mfeurer merged 1 commit intomasterfrom
fix_ordering_of_categorical_hyperparamter
Dec 15, 2021
Merged

Fixes equality with ordering of hyperparameters#212
mfeurer merged 1 commit intomasterfrom
fix_ordering_of_categorical_hyperparamter

Conversation

@eddiebergman
Copy link
Contributor

Fixes #73 in which the following use to be false but is fixed to be true.

f7 = CategoricalHyperparameter("param", ["a", "b"])
f7_ = CategoricalHyperparameter("param", ["b", "a"])
assert f7 == f7_

@eddiebergman eddiebergman requested a review from mfeurer December 15, 2021 14:40
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #212 (d117338) into master (b6aa830) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files          17       17           
  Lines        1629     1629           
=======================================
  Hits         1094     1094           
  Misses        535      535           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6aa830...d117338. Read the comment docs.

@mfeurer mfeurer merged commit 4d69931 into master Dec 15, 2021
@mfeurer mfeurer deleted the fix_ordering_of_categorical_hyperparamter branch December 15, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Equals operator for choices

2 participants