Skip to content

Fix #225: almost_equal on get_neighbours test#226

Merged
eddiebergman merged 2 commits intomasterfrom
fix_test_normalfloat
Jan 26, 2022
Merged

Fix #225: almost_equal on get_neighbours test#226
eddiebergman merged 2 commits intomasterfrom
fix_test_normalfloat

Conversation

@eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Jan 26, 2022

It seems when building a bdist, the RandomState.normal can be slightly unpredictable when comparing two arches x86_64 and i686, at least past the 14th decimal.

See #225 for more.

@eddiebergman eddiebergman linked an issue Jan 26, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #226 (b8907e8) into master (c67b347) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files          17       17           
  Lines        1627     1627           
=======================================
  Hits         1092     1092           
  Misses        535      535           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67b347...b8907e8. Read the comment docs.

@eddiebergman eddiebergman merged commit de8d398 into master Jan 26, 2022
@mfeurer mfeurer deleted the fix_test_normalfloat branch January 26, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure test_normalfloat

1 participant