Merged
Conversation
mfeurer
approved these changes
Jan 27, 2022
Contributor
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Looks good to me. Just checking, why doesn't this trigger tests on CI right now?
Contributor
Author
|
Generally means bad syntax in the file. It was because I couldn't specify a non-list argument to the |
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 67.11% 67.11%
=======================================
Files 17 17
Lines 1627 1627
=======================================
Hits 1092 1092
Misses 535 535 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables testing for windows and mac by making the using
shell: bashin the workflow.