Various autotest_regression fixes#683
Merged
ypu merged 3 commits intoautotest:nextfrom Aug 9, 2013
Merged
Conversation
added 3 commits
July 28, 2013 20:18
Fix TypeError: not enough arguments for format string Found by PyCharm inspection. Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
I think we mean ValueError here, I couldn't find any error.ValueError. Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
… try/except We need the install log file to debug any error, so move it outside the try/except, otherwise any errors will trigger aexpect.ShellCmdError and skip the copy Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
Member
|
LGTM |
Member
|
Hi Ross, thank you for your fixes. Acked-by: Lukáš Doktor ldoktor@redhat.com |
Member
|
As already get two Ack. Merge it. Thanks @rbbratta |
FengYang
pushed a commit
to FengYang/virt-test
that referenced
this pull request
Nov 12, 2013
Merge autotest and virttest cgroup_utils library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autotest_regression: Too few arguments for format string
Fix TypeError: not enough arguments for format string
Found by PyCharm inspection.
autotest_regression: replace error.ValueError with ValueError
I think we mean ValueError here, I couldn't find any error.ValueError.
autotest_regression: move copy of install-autotest-server*log outside try/except
We need the install log file to debug any error, so move it outside the
try/except, otherwise any errors will trigger aexpect.ShellCmdError and
skip the copy