libvirt: fix for Virsh edit test#710
Merged
yangdongsheng merged 2 commits intoautotest:nextfrom Aug 9, 2013
yangdongsheng:virsh_edit
Merged
libvirt: fix for Virsh edit test#710yangdongsheng merged 2 commits intoautotest:nextfrom yangdongsheng:virsh_edit
yangdongsheng merged 2 commits intoautotest:nextfrom
yangdongsheng:virsh_edit
Conversation
Member
Author
|
@cevich I need an ACK for this patchset. Could you take a quick look at it . Thx |
added 2 commits
August 7, 2013 22:03
* we can not assume the guest with 1 vcpu. Change the pattern in sed from `1<\/vcpu>` to `[0-9]*<\/vcpu>` * add a vcpucount function in virsh module. And use it in virsh_edit to get the vcpucount of VM. Signed-off-by: yangdongsheng <yangds.fnst@cn.fujitsu.com>
Signed-off-by: yangdongsheng <yangds.fnst@cn.fujitsu.com>
Member
Author
|
well thanx @liyangfnst for your comments. |
Member
|
Yep, this is fine by me. |
Member
Author
|
Ok, Thanx @liyangfnst and @cevich . pushing to next. |
yangdongsheng
pushed a commit
that referenced
this pull request
Aug 9, 2013
libvirt: fix for Virsh edit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.