Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

Conversation

@RodrigoVillar
Copy link
Contributor

@RodrigoVillar RodrigoVillar commented Nov 18, 2025

Why this should be merged

Updates firewood-go-ethhash to use the latest Firewood version (v0.0.15), which enables archival mode for Firewood.

How this works

  • Updates code to use new ffi.Hash type
  • Removes restriction on using Firewood with pruning disabled
    • Imposes new restriction on opening Firewood without missing trie repopulation.
    • Firewood can now be configured to run in archival mode.
  • Updates + adds tests

How this was tested

  • Updates the TestArchiveBlockChainSnapsDisabled() test to use Firewood
  • Adds a TestPruningToNonPruning() test to verify expected behavior of HashDB and Firewood when switching from pruning to archival mode.

Need to be documented?

Yes

Need to update RELEASES.md?

Yes

@RodrigoVillar RodrigoVillar marked this pull request as ready for review November 19, 2025 21:03
@RodrigoVillar RodrigoVillar requested review from a team and alarso16 as code owners November 19, 2025 21:03
Copy link
Contributor

@alarso16 alarso16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update plugin/evm/config/config.md and RELEASES.md

@RodrigoVillar RodrigoVillar added the dependencies Pull requests that update a dependency file label Nov 20, 2025
Copy link
Contributor

@alarso16 alarso16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you rename this PR? It's mostly about enabling archival mode for firewood, which is a feature, not just updating dependencies

@RodrigoVillar RodrigoVillar changed the title chore: bump firewood-go-ethhash to v0.0.15 feat: enable archival mode for Firewood Nov 21, 2025
@ceyonur ceyonur enabled auto-merge November 24, 2025 14:57
@ceyonur ceyonur disabled auto-merge November 24, 2025 15:02
@ceyonur ceyonur added this pull request to the merge queue Nov 24, 2025
Merged via the queue into master with commit 7629fa1 Nov 24, 2025
11 checks passed
@ceyonur ceyonur deleted the rodrigo/bump-firewood-v0.0.15 branch November 24, 2025 15:45
alarso16 pushed a commit to ava-labs/subnet-evm that referenced this pull request Nov 24, 2025
alarso16 pushed a commit to ava-labs/subnet-evm that referenced this pull request Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file requires-subnet-evm-port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: bump firewood-go-ethhash to v0.0.15 Enable Firewood Archival Support

4 participants