Merged
Conversation
mpardesh
commented
Jan 18, 2023
| } | ||
| if !query_width_used { | ||
| panic!("Query width unused, check rule!"); | ||
| //panic!("Query width unused, check rule!"); |
Collaborator
Author
There was a problem hiding this comment.
I wouldn't land like this, but I'm not sure what the right annotations for examples/sdiv/sdiv.isle would be otherwise
Owner
There was a problem hiding this comment.
It looks like x should be able to be something like 32 here though, no?
rule 1 (lower (has_type (fits_in_64 ty) (sdiv x (iconst (safe_divisor_from_imm64 y)))))
(a64_sdiv $I64 (put_in_reg_sext64 x) (imm ty (ImmExtend.Sign) y)))
avanhatt
approved these changes
Mar 21, 2023
avanhatt
pushed a commit
that referenced
this pull request
May 26, 2023
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 18, 2024
Adds macro support to the spec language. Syntax for definitions: ``` (macro (bvone n) (zero_ext n #b1)) ``` Expansion: ``` (bvone! 64) ``` This PR also adds a couple of macros to a new `prelude_spec.isle`. Closes avanhatt#39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdivexample fails the "query width used" check, but all the terms seem to explicitly want 64 bit bvs