Merged
Conversation
avanhatt
pushed a commit
that referenced
this pull request
May 26, 2023
* On Windows, ignore access-denied errors from `sync_all`. On Windows `sync_all` does `FlushFileBuffers` which fails with an access-denied error if the file not opened for writing. Ignore this error, for compatibility with POSIX-style APIs. Fixes #66. * Ignore `ERROR_ACCESS_DENIED` from `sync_data` too. * Temporarily disable directory syncing for now.
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Sep 22, 2024
When generating specs from ASLp, we have to define a mapping between spec inputs and variables in the derived constraints. Previously we would do this lazily by introducing equality constraints. This not only looks awful avanhatt#62, but anecdotally may also have solver performance implications. This PR updates the spec generation to substitute the mapped expressions for the variables instead. Updates avanhatt#62 #37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.