Skip to content

Fix broken broken tests#78

Merged
mmcloughlin merged 1 commit intoverify-mainfrom
mbm/fix-broken-broken-tests
Nov 2, 2023
Merged

Fix broken broken tests#78
mmcloughlin merged 1 commit intoverify-mainfrom
mbm/fix-broken-broken-tests

Conversation

@mmcloughlin
Copy link
Collaborator

@mmcloughlin mmcloughlin commented Nov 2, 2023

Updates some of the "broken" test cases to ensure they have full enum types.

These were failing with errors such as:

---- test_broken_iadd_shift2 stdout ----
Verifying iadd rules in file: ./examples/broken/iadd/broken_shift2.isle
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', cranelift/isle/veri/veri_engine/src/annotations.rs:322:85
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'test_broken_iadd_shift2' panicked at 'called `Result::unwrap()` on an `Err` value: Error { error: "Test thread panicked Any { .. }", total_delay: 0ns, tries: 1 }', cranelift/isle/veri/veri_engine/tests/utils/mod.rs:109:12

Following the change in #73, we now error if an enum model does not have a corresponding type declaration. This PR fixes the problem by adding full enum type declarations alongside the models.

@mmcloughlin mmcloughlin requested a review from avanhatt November 2, 2023 19:40
@mmcloughlin mmcloughlin marked this pull request as ready for review November 2, 2023 19:41
Copy link
Owner

@avanhatt avanhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch!

@mmcloughlin mmcloughlin merged commit 1a77c5f into verify-main Nov 2, 2023
@mmcloughlin mmcloughlin deleted the mbm/fix-broken-broken-tests branch November 2, 2023 22:16
avanhatt pushed a commit to wellesley-prog-sys/wasmtime that referenced this pull request Oct 9, 2024
Run ISA spec generation in CI.

Closes avanhatt#66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants