veri: remove type ids from annotation_ir#88
Merged
mmcloughlin merged 2 commits intoverify-mainfrom Feb 14, 2024
Merged
Conversation
avanhatt
approved these changes
Feb 14, 2024
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Support generating ASLp specifications that split based on an enum `match`. Update the existing `MInst` specs to use this feature where possible. Updates avanhatt#48 #35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the type ID fields from
annotation_irtypes. They arecurrently all set to 0 and unused, so their presence ends up being a bit
confusing. I think it's better to delete them if they're not used.