Skip to content

fix: skip non-Java URIs in jdtls diagnostics callback#49

Merged
aviadshiber merged 1 commit intomainfrom
fix/skip-directory-uris
Apr 11, 2026
Merged

fix: skip non-Java URIs in jdtls diagnostics callback#49
aviadshiber merged 1 commit intomainfrom
fix/skip-directory-uris

Conversation

@aviadshiber
Copy link
Copy Markdown
Owner

Summary

  • Skip non-.java URIs in _on_jdtls_diagnostics to prevent [Errno 21] Is a directory errors
  • jdtls publishes diagnostics for directory URIs and build config files during workspace init — our custom analysis only applies to Java files
  • Works for both Maven and Gradle projects

Test plan

  • All 361 tests pass
  • Pre-commit checks pass (lint, format, type check, coverage)
  • Manual: open LSP against products repo, verify no directory errors in logs

🤖 Generated with Claude Code

jdtls publishes diagnostics for directory URIs and build files during
workspace initialization. The callback tried to read these as text
documents, causing [Errno 21] Is a directory errors.

Only run custom analysis on .java URIs — works for both Maven and Gradle.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@aviadshiber aviadshiber merged commit 9235820 into main Apr 11, 2026
14 checks passed
@aviadshiber aviadshiber deleted the fix/skip-directory-uris branch April 11, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants