Ros2 humble - remaining flatland_server tests#90
Merged
josephduchesne merged 14 commits intoavidbots:ros2-humblefrom Dec 21, 2022
Merged
Ros2 humble - remaining flatland_server tests#90josephduchesne merged 14 commits intoavidbots:ros2-humblefrom
josephduchesne merged 14 commits intoavidbots:ros2-humblefrom
Conversation
JoaoCostaIFG
commented
Nov 27, 2022
- Finished the migration to ros2 of the remaining flatland_server tests
- Fixed a problem on YamlPreprocessor: get_parameter usage changed
- Fixed some integer comparison problems in tests: comparing integers of different sizes
- Added a translation of flatland_server's launch file to the new/recommended python syntax
- Removed the remaining, unused test launch files
Fix usage of get_parameter in YamlPreprocessor. Change integer in yaml out-file to floating point number (result of a calculation in lua).
Author
|
The pipeline test that failed appears to be related to the system's
My friend's system has |
Collaborator
|
Thanks for this contribution. The changes look good and CI is happy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.