-
Notifications
You must be signed in to change notification settings - Fork 17
Add quickstart instructions for running CI checks locally #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aviralgarg05
merged 6 commits into
aviralgarg05:main
from
Jagriti-student:add-local-ci-instructions
Dec 19, 2025
+87
−18
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b052329
Add basic evaluation example script
Jagriti-student dd2f4fe
Fix typos and improve clarity in docstrings across core modules
Jagriti-student 80b0706
Add Google-style docstrings to BaseAdapter methods
Jagriti-student 8e7b8c1
Format base adapter using ruff
Jagriti-student 0669ffd
docs: add instructions for running CI checks locally
Jagriti-student fe9d27b
Remove example file unrelated to CI documentation
Jagriti-student File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,23 @@ | ||
| """Custom exceptions for AgentUnit.""" | ||
| """ | ||
| Custom exceptions for AgentUnit. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
|
|
||
| class AgentUnitError(Exception): | ||
| """Base class for AgentUnit exceptions.""" | ||
| """ | ||
| Base class for AgentUnit exceptions. | ||
| """ | ||
|
|
||
|
|
||
| class AdapterNotAvailableError(AgentUnitError): | ||
| """Raised when an adapter cannot be initialized due to missing dependencies.""" | ||
| """ | ||
| Raised when an adapter cannot be initialized due to missing dependencies. | ||
| """ | ||
|
|
||
|
|
||
| class ScenarioExecutionError(AgentUnitError): | ||
| """Raised when a scenario fails during execution.""" | ||
| """ | ||
| Raised when a scenario fails during execution. | ||
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| """Scenario runner orchestration.""" | ||
| """ | ||
| Scenario runner orchestration. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Section is incomplete - missing CI check commands.
This section addresses issue #3 but is incomplete. According to the acceptance criteria, you need to document how to run:
poetry check- verify Poetry configpoetry run ruff check .- run lintingpoetry run ruff format --check .- verify formattingpoetry run pytest- run testsCurrently, only the setup (
poetry install --with dev) is shown. Additionally, the AI summary mentions this content "appears twice in the diff" - please verify there's no duplication in the README.Apply this diff to complete the section:
+#### Verify Your Changes
+
+Run these commands before opening a pull request:
+
+
bash +# Verify pyproject.toml and lock file consistency +poetry check + +# Lint code with ruff +poetry run ruff check . + +# Verify code formatting +poetry run ruff format --check . + +# Run all tests +poetry run pytest ++
+If formatting issues are detected, you can auto-fix them:
+
+
bash +poetry run ruff format . +In README.md around lines 206 to 219, the "Running CI Checks Locally" section
only shows setup but is missing the CI verification commands; add a "Verify Your
Changes" subsection immediately after the existing "poetry install --with dev"
block that lists the required commands (poetry check, poetry run ruff check .,
poetry run ruff format --check ., poetry run pytest) and mention how to auto-fix
formatting with poetry run ruff format ., and also scan the README for any
duplicate copies of this section and remove the duplicate so the instructions
appear only once.