Merged
Conversation
This is to clearly delineate where code is stored for the example compared to actual.
This is so we can reduce the steps in the README and abstract as much away from the actual generation and loading of the example data for users.
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 3 3
Lines 144 144
Branches 32 32
=======================================
Hits 110 110
Misses 24 24
Partials 10 10 Continue to review full report at Codecov.
|
This is so there is a clean workspace for users to write to.
This is so CI/D checks pass.
ca8af7e to
5e3ccbf
Compare
This is so we can explain how users can generate their own data.
5e3ccbf to
9bdaa2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch shifts the example data to its own separate folder and then loads into the database so we can keep the workspace clean for users when they want to add their own files and generate their own data.
Changes
The high-level changes made in this PR are:
example/sqlsubdirectory.docker-compose.ymlandDockerfileto generate and load data fromexample/neo4jinto the database.examplesubdirectory.Please see the commit history for more detailed changes.
Check
docker-compose up.