Skip to content

Feature: Dockerfile#16

Merged
avisionh merged 5 commits intomainfrom
feature/dockerfile
Jun 14, 2021
Merged

Feature: Dockerfile#16
avisionh merged 5 commits intomainfrom
feature/dockerfile

Conversation

@avisionh
Copy link
Owner

@avisionh avisionh commented Jun 13, 2021

Summary

This branch shifts the example data to its own separate folder and then loads into the database so we can keep the workspace clean for users when they want to add their own files and generate their own data.

Changes

The high-level changes made in this PR are:

  1. Move example queries into their own example/sql subdirectory.
  2. Update docker-compose.yml and Dockerfile to generate and load data from example/neo4j into the database.
  3. Move the testing scripts to refer to example subdirectory.

Please see the commit history for more detailed changes.


Check

  • Can deploy the database with example data pre-loaded via docker-compose up.
  • The test suite passes via running the below:
python -m pytest tests/
  • The GitHub Actions checks pass.

avisionh added 2 commits June 13, 2021 22:45
This is to clearly delineate where code is stored for the example compared to actual.
This is so we can reduce the steps in the README and abstract as much away from the actual generation and loading of the example data for users.
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #16 (9bdaa2e) into main (d1b1a18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files           3        3           
  Lines         144      144           
  Branches       32       32           
=======================================
  Hits          110      110           
  Misses         24       24           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b1a18...9bdaa2e. Read the comment docs.

This is so there is a clean workspace for users to write to.
@avisionh avisionh marked this pull request as ready for review June 14, 2021 08:19
This is so CI/D checks pass.
@avisionh avisionh force-pushed the feature/dockerfile branch 2 times, most recently from ca8af7e to 5e3ccbf Compare June 14, 2021 08:33
This is so we can explain how users can generate their own data.
@avisionh avisionh force-pushed the feature/dockerfile branch from 5e3ccbf to 9bdaa2e Compare June 14, 2021 08:35
@avisionh avisionh merged commit fabe5c7 into main Jun 14, 2021
@avisionh avisionh deleted the feature/dockerfile branch June 14, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant