fix(security): prevent XSS attacks and URL injection vulnerabilities#2
Open
awara-coder wants to merge 1 commit intomainfrom
Open
fix(security): prevent XSS attacks and URL injection vulnerabilities#2awara-coder wants to merge 1 commit intomainfrom
awara-coder wants to merge 1 commit intomainfrom
Conversation
Critical security improvements to eliminate XSS and CSP bypass vulnerabilities. Changes: 1. Added validator.js utility with URL and email validation - isValidUrl(): Validates URLs against allowed protocols (http/https/mailto) - sanitizeUrl(): Returns safe URL or '#' fallback - isValidEmail(): Basic email format validation 2. Fixed inline event handler in experience.js (CSP bypass) - Removed onerror="this.remove()" inline handler - Replaced with addEventListener for proper error handling - Prevents Content Security Policy bypass 3. Applied URL sanitization to projects.js - Sanitized project.link before href assignment - Sanitized project.github before href assignment - Prevents javascript: and data: URL injection Security Impact: - Eliminates inline event handler CSP bypass vulnerability - Prevents javascript: URL injection attacks - Validates all external URLs before use in href attributes - Adds defense-in-depth for URL-based XSS vectors Testing: - Malicious URLs (javascript:alert(1)) now sanitized to '#' - Only http/https/mailto protocols allowed - Relative paths (/, #) still supported 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical security improvements to eliminate XSS and CSP bypass vulnerabilities.
Changes:
Added validator.js utility with URL and email validation
Fixed inline event handler in experience.js (CSP bypass)
Applied URL sanitization to projects.js
Security Impact:
Testing:
🤖 Generated with Claude Code