fix(memory): prevent memory leaks in IntersectionObserver and event l…#6
Open
awara-coder wants to merge 1 commit intomainfrom
Open
fix(memory): prevent memory leaks in IntersectionObserver and event l…#6awara-coder wants to merge 1 commit intomainfrom
awara-coder wants to merge 1 commit intomainfrom
Conversation
…isteners Eliminates memory leaks that caused unbounded memory growth on component re-renders. Changes: 1. projects.js - IntersectionObserver cleanup - Added module-level projectObserver variable - Disconnect previous observer before creating new one - Unobserve elements after animation completes - Added cleanupProjects() export for manual cleanup 2. mobileMenu.js - Event listener cleanup - Store event handler functions for proper removal - Auto-cleanup on reinitialization - Added cleanup() export for manual cleanup - Remove document-level listener to prevent accumulation Memory Leak Impact: - Before: IntersectionObserver accumulated on each populateProjects() call - Before: Document click listener persisted indefinitely - After: Observers properly disconnected and freed - After: All event listeners can be cleanly removed Performance Impact: - Prevents unbounded memory growth - Reduces DOM traversal overhead (.contains() on every click) - Frees memory after animations complete - Enables proper cleanup in SPA scenarios 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…isteners
Eliminates memory leaks that caused unbounded memory growth on component re-renders.
Changes:
projects.js - IntersectionObserver cleanup
mobileMenu.js - Event listener cleanup
Memory Leak Impact:
Performance Impact:
🤖 Generated with Claude Code