chore: secure github actions using hash instead of versions#1232
chore: secure github actions using hash instead of versions#1232scottgerring merged 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
============================================
- Coverage 79.35% 78.93% -0.43%
- Complexity 641 652 +11
============================================
Files 73 74 +1
Lines 2446 2506 +60
Branches 253 259 +6
============================================
+ Hits 1941 1978 +37
- Misses 425 446 +21
- Partials 80 82 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scottgerring
left a comment
There was a problem hiding this comment.
I think this is an improvement on how it is today and we should merge it.
I also think in a subsequent task it is worth digging into the smaller 3rd party actions - e.g. ahmadnassri/action-workflow-run-wait, release-drafter/release-drafter, and jacobtomlinson/gha-find-replace and checking if we can't get away with some github 1st party action, or, a powertools shared action, or failing the previous options reviewing the code of the thing.
|
@jeromevdl I think we should merge this - wdyt? |
|
agree! |
02da4b7 to
1bdb1c7
Compare
|
except that build fails without clear reason why... |
It was because of the docs.yaml deleted by @kozub, the merge didn't work well... I've deleted it. |
sthulb
left a comment
There was a problem hiding this comment.
This can be merged assuming the code at each of the hashes has been reviewed to be safe.
|
Kudos, SonarCloud Quality Gate passed! |








Issue #, if available:
Description of changes:
Replace all explicit versions with hashes to pin to a specific version.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.