Skip to content

chore: secure github actions using hash instead of versions#1232

Merged
scottgerring merged 4 commits intomainfrom
gh-actions-hash
Aug 24, 2023
Merged

chore: secure github actions using hash instead of versions#1232
scottgerring merged 4 commits intomainfrom
gh-actions-hash

Conversation

@jeromevdl
Copy link
Copy Markdown
Contributor

@jeromevdl jeromevdl commented Jun 23, 2023

Issue #, if available:

Description of changes:

Replace all explicit versions with hashes to pin to a specific version.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl jeromevdl requested a review from sthulb June 23, 2023 12:01
@jeromevdl jeromevdl self-assigned this Jul 10, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 21, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.93%. Comparing base (1261e58) to head (8a90e41).
⚠️ Report is 691 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1232      +/-   ##
============================================
- Coverage     79.35%   78.93%   -0.43%     
- Complexity      641      652      +11     
============================================
  Files            73       74       +1     
  Lines          2446     2506      +60     
  Branches        253      259       +6     
============================================
+ Hits           1941     1978      +37     
- Misses          425      446      +21     
- Partials         80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement on how it is today and we should merge it.

I also think in a subsequent task it is worth digging into the smaller 3rd party actions - e.g. ahmadnassri/action-workflow-run-wait, release-drafter/release-drafter, and jacobtomlinson/gha-find-replace and checking if we can't get away with some github 1st party action, or, a powertools shared action, or failing the previous options reviewing the code of the thing.

@scottgerring
Copy link
Copy Markdown
Contributor

@jeromevdl I think we should merge this - wdyt?

@jeromevdl
Copy link
Copy Markdown
Contributor Author

agree!

@jeromevdl
Copy link
Copy Markdown
Contributor Author

except that build fails without clear reason why...

@jeromevdl
Copy link
Copy Markdown
Contributor Author

except that build fails without clear reason why...

It was because of the docs.yaml deleted by @kozub, the merge didn't work well... I've deleted it.

Copy link
Copy Markdown
Contributor

@sthulb sthulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged assuming the code at each of the hashes has been reviewed to be safe.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@scottgerring scottgerring merged commit 787aa9d into main Aug 24, 2023
@scottgerring scottgerring deleted the gh-actions-hash branch August 24, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants