chore: [V2] rename 'core' module to 'common'#1364
Merged
scottgerring merged 12 commits intov2from Aug 24, 2023
Merged
Conversation
jeromevdl
reviewed
Aug 15, 2023
...ls-common/src/main/java/software/amazon/lambda/powertools/core/internal/LambdaConstants.java
Show resolved
Hide resolved
Contributor
Author
|
We still have Now it is a little less wrong - it is the concept of "core utilities", which are split over What should we call the example? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #1364 +/- ##
=====================================
Coverage ? 77.20%
Complexity ? 522
=====================================
Files ? 64
Lines ? 2136
Branches ? 223
=====================================
Hits ? 1649
Misses ? 415
Partials ? 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Fixed namespace |
jeromevdl
reviewed
Aug 21, 2023
scottgerring
commented
Aug 22, 2023
2 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
jeromevdl
pushed a commit
that referenced
this pull request
Aug 30, 2023
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
jeromevdl
pushed a commit
that referenced
this pull request
Oct 12, 2023
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
jeromevdl
pushed a commit
that referenced
this pull request
Oct 12, 2023
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
jeromevdl
pushed a commit
that referenced
this pull request
Oct 13, 2023
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1076
Description of changes:
The Java 'core' module has nothing to do with the powertools concept of 'core' utilities - logging, tracing, metrics - but is rather common functionality shared by the other PT modules.
To clarify this distinction, we will rename this to 'powertools-common', which fits with the other PT libraries naming scheme.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.