docs: Adding Kotlin example.#1454
Conversation
There was a problem hiding this comment.
Hey @jasoniharris thanks for the contribution!
Apropos build - I think something funny is going on in actions. I will re-run tomorrow and see if it self-resolves, else we can dive deeper. Doesn't seem to be related to your change.
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
|
Deploying with SAM: I end up with: and a stacktrace in the logs: Have I missed something? |
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
I think we need to update the instructions. The correct way with SAM should be |
… Kotlin examples.
…tests too and is more idiomatic and readme to be more descriptive
examples/powertools-examples-core/kotlin/gradle/build.gradle.kts
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/gradle/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
… Kotlin examples.
…tests too and is more idiomatic and readme to be more descriptive
# Conflicts: # examples/README.md
scottgerring
left a comment
There was a problem hiding this comment.
This is good for me. The E2E tests fail because of the security config, not an issue with the PR. @jeromevdl do you want to have a skim before we merge to make sure i've not missed anything funny given recent repo structure issues?
jeromevdl
left a comment
There was a problem hiding this comment.
a few minor things and we're good
pom.xml
Outdated
| <module>powertools-e2e-tests</module> | ||
| <module>powertools-batch</module> | ||
| <module>examples</module> | ||
| <!-- <module>examples</module>--> |
There was a problem hiding this comment.
Should be removed
| <!-- <module>examples</module>--> |
|
Kudos, SonarCloud Quality Gate passed! |
|
Thanks @jasoniharris and @AlexeySoshin ! |








Issue #, if available:
Description of changes:
Adding an example for Kotlin with Gradle- harrzjas@amazon.co.uk
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.