feat(idempotency): Add support for ReturnValuesOnConditionCheckFailure in Idempotency.#1821
Merged
feat(idempotency): Add support for ReturnValuesOnConditionCheckFailure in Idempotency.#1821
Conversation
…lure in Idempotency.
|
phipag
commented
Apr 22, 2025
...core/src/main/java/software/amazon/lambda/powertools/idempotency/persistence/DataRecord.java
Show resolved
Hide resolved
dreamorosi
approved these changes
Apr 22, 2025
Contributor
dreamorosi
left a comment
There was a problem hiding this comment.
Great work on the PR, I left two comments but you can resolve if you don't find them relevant.
Also TIL about transient - neat!
...core/src/main/java/software/amazon/lambda/powertools/idempotency/persistence/DataRecord.java
Show resolved
Hide resolved
...core/src/main/java/software/amazon/lambda/powertools/idempotency/persistence/DataRecord.java
Show resolved
Hide resolved
Contributor
|
@phipag feel free to merge any time. No rush - just letting you know I'm ok with the comments and have resolved all the threads. |
Contributor
Author
|
Awesome! Thanks for your prompt review. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue #, if available: #1784
Description of changes:
This feature avoids redundant DynamoDB calls in the Idempotency utility by making use of the
ReturnValuesOnConditionCheckFailureoption in the AWS SDK.Instead of re-fetching a data record from the persistence store when a
IdempotencyItemAlreadyExistsExceptionis thrown, it attaches the offending data record to the exception so that it can be directly returned to the caller without making another DynamoDB call.Note: In addition to unit tests, I ran E2E tests as well. Until E2E tests are restored in GitHub workflows, here is the output from running in my AWS account.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.