fix(parser): raise ValidationError when SNS->SQS keys are intentionally missing

[rubenfonseca]

Issue number: #1009

Summary

Changes

When UnsubscribeURL or SigningCertURL were intentionally missing from the SNS -> SQS payload, KeyError was thrown.

Since the objective of the parser is to validate the payload, we changed the code so it returns
an expected ValidationError instead.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of my this change
• Changes are tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

[codecov-commenter]

Codecov Report

Merging #1299 (a7f0562) into develop (b852946) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1299   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files          119      119           
  Lines         5427     5427           
  Branches       619      619           
========================================
  Hits          5421     5421           
  Misses           2        2           
  Partials         4        4           

Impacted Files	Coverage Δ
...s_lambda_powertools/utilities/parser/models/sns.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b852946...a7f0562. Read the comment docs.

[heitorlessa]

Looks great, a minor suggestion to make the tests more explicit. Super excited to see your first PR ;-)

[rubenfonseca]

@heitorlessa thank you for the feedback, it makes 100% sense! 😎

[heitorlessa]

Thanks a lot @rubenfonseca ;)