feat: add support for SNS->SQS protocol#272
Merged
heitorlessa merged 2 commits intodevelopfrom Jan 19, 2021
Merged
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
nmoutschen
approved these changes
Jan 19, 2021
Contributor
nmoutschen
left a comment
There was a problem hiding this comment.
LGTM - just 2 small remarks
heitorlessa
commented
Jan 19, 2021
Contributor
Author
heitorlessa
left a comment
There was a problem hiding this comment.
responded to comments; merging
heitorlessa
commented
Jan 19, 2021
Contributor
Author
heitorlessa
left a comment
There was a problem hiding this comment.
responded to comments; merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #265
Description of changes:
When using SNS -> SQS -> Lambda, the SNS payload differs from SNS -> Lambda. It's not explicitly documented as per #262 - This information is available on per Target protocol, and Lambda is the only one that seems to differ from others (e.g. SQS, HTTP, etc.)
This PR does the following:
MessageAttributesto be an optional fieldUnsubscribeURL -> UnsubscribeUrl, andSigningCertURL -> SigningCertUrlto make backwards compatibleSnsSqsEnvelopeto make this process seamless for customersExcerpt from tests, where customers can continue to write their parsing as before, but use a new envelopes.SnsSqsEnvelope to correctly extract the original SNS payload that was doubled marshalled too.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.