docs(event_handler): use correct correlation_id for logger in middleware example#3063
Merged
heitorlessa merged 4 commits intoaws-powertools:developfrom Sep 8, 2023
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
pull-request-size
Bot
added
the
size/XS
github-actions
Bot
added
the
documentation
leandrodamascena
approved these changes
Sep 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Sep 8, 2023
* develop: chore: cleanup, add test for single and nested fix(parameters): make cache aware of single vs multiple calls docs(event_handler): use correct correlation_id for logger in middleware example (aws-powertools#3063) chore(deps-dev): bump pytest from 7.4.1 to 7.4.2 (aws-powertools#3057)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #953
Summary
In the example we're about to go live, we've used
request_idwhen setting correlation ID for Logger whilst doing the correct behaviour forapp.append_context.A tiny typo that could've degraded customers experience when learning how to do it :)
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.